Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

footer is too specialized for rustc's needs #96

Closed
epage opened this issue Mar 12, 2024 · 1 comment · Fixed by #98
Closed

footer is too specialized for rustc's needs #96

epage opened this issue Mar 12, 2024 · 1 comment · Fixed by #98
Labels
C-enhancement Category: enhancement M-breaking-change Meta: Implementing or merging this will introduce a breaking change
Milestone
Rust Adoption

Comments

@epage
Copy link
Contributor

epage commented Mar 12, 2024

footer only allows Labels when rustc has a more general concept of "children" that can either be Labels or more Messages
@epage
Copy link
Contributor Author

epage commented Mar 12, 2024

Some options

  • Remove footer and have the caller create more Messages
    • We'll need a way for users to designate the "primary" Message
  • extend footer to take in Message

@epage epage added the C-enhancement Category: enhancement label Mar 12, 2024
@epage epage added this to the Rust Adoption milestone Mar 12, 2024
@epage epage added the M-breaking-change Meta: Implementing or merging this will introduce a breaking change label Mar 12, 2024
epage added a commit to epage/annotate-snippets-rs that referenced this issue Mar 12, 2024
@epage
fix!: Generalize footer to be any Message
ce736be 
Fixes rust-lang#96
@epage epage mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: enhancement M-breaking-change Meta: Implementing or merging this will introduce a breaking change
Projects
None yet
Milestone
Rust Adoption
Development

Successfully merging a pull request may close this issue.

fix!: Generalize footer to be any Message epage/annotate-snippets-rs
1 participant
@epage