Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"modern" API, take cad.3 #14

Closed
wants to merge 4 commits into from
Closed

"modern" API, take cad.3 #14

wants to merge 4 commits into from

Conversation

CAD97
Copy link

@CAD97 CAD97 commented Oct 21, 2019

Closes #13. See #13 for more details.

@CAD97
Copy link
Author

CAD97 commented Oct 21, 2019

For clarity, since most of the code moved around and was adjusted: API design is by me, implementation code is directly adapted from the cleanup branch. I'd still suggest expanding package.authors to the authors credited in annotate-snippets, codespan, language-reporting, and retort:

authors = [
    "Brendan Zabarauskas <bjzaba@yahoo.com.au>",
    "Christopher Durham (CAD97) <cad97@cad97.com>",
    "Yehuda Katz <wycats@gmail.com>",
    "Zibi Braniecki <gandalf@mozilla.com>",
] # alphabetical order

but that's directly up to the package maintainer. All code in this PR is either original or adapted from this package, though API design is inspired by all of the above.

src/span.rs Show resolved Hide resolved
@epage
Copy link
Contributor

epage commented Mar 13, 2024

We did a major re-work of the API in #90 and #91.

While there are ideas that could be broken out into their own Issue here, I'm going to close this as this form of the API isn't likely to move forward.

@epage epage closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants