-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libbacktrace cannot be updated in Rust's libstd because of memchr dependency #432
Comments
I'm not sure what this is, but if there's a non-invasive patch for memchr, I would be happy to accept a PR and get a release out quickly. Of course, without looking carefully, it's likely that memchr could be made optional since all of its public APIs have corresponding simple and naive implementations. |
I'll work on sending a PR to [dependencies]
# Internal feature, only used when building as part of libstd, not part of the
# stable interface of this crate.
core = { version = '1.0.0', optional = true, package = 'rustc-std-workspace-core' }
alloc = { version = '1.0.0', optional = true, package = 'rustc-std-workspace-alloc' }
compiler_builtins = { version = '0.1.2', optional = true }
[features]
# Internal feature, only used when building as part of libstd, not part of the
# stable interface of this crate.
rustc-dep-of-std = ['core', 'alloc', 'compiler_builtins'] The fix at that point would be to add a line here enabling the |
@nagisa added the memchr dependency for better performance when used in rustc, so updating the memchr crate seems best. |
This accompanies BurntSushi/memchr#89 to help resolve rust-lang/backtrace-rs#432
I've sent BurntSushi/memchr#89 for |
This commit adds the necessary `Cargo.toml` directives which enables this crate to build with the standard library. This introduces some optional off-by-deault dependencies which are only activated (and overwritten) when built as part of the standard library. Ref rust-lang/backtrace-rs#432 PR #89
This accompanies BurntSushi/memchr#89 to help resolve rust-lang/backtrace-rs#432
This commit updates the backtrace crate in libstd now that dependencies have been updated to use `memchr` from the standard library as well. This is mostly just making sure deps are up-to-date and have all the latest-and-greatest fixes and such. Closes rust-lang/backtrace-rs#432
…-Simulacrum Update the backtrace crate in libstd This commit updates the backtrace crate in libstd now that dependencies have been updated to use `memchr` from the standard library as well. This is mostly just making sure deps are up-to-date and have all the latest-and-greatest fixes and such. Closes rust-lang/backtrace-rs#432
Updated now! |
Thank you! |
I suppose that this is more a tracking issue for a downstream problem, but it seems to make sense to raise it here.
In libbacktrace 0.2.60, the dependency on object has been raised to 0.25.0. This release contains an unconditional dependency on memchr. This crate does not support the
rustc-std-workspace-core
workaround.If the backtrace version shipped with
rustc
needs to be set higher than 0.3.59, this problem needs to be solved.CC: @BurntSushi CC: @philipc @fitzgen
The text was updated successfully, but these errors were encountered: