Make cargo compile against the nightly (url crate changes) #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Jul 7, 2014
On rust-lang/rust@ed47c47 (which landed yesterday via rust-lang/rust@b8ef5cf), `url.path` now returns a `Path`, not a `String`. This one-line patch makes cargo compile again (at least as of rust-lang/rust@b8ef5cf, the `crate_id` changes haven't reached me yet).
bors
added a commit
that referenced
this pull request
Jul 7, 2014
This solves warnings about the use of the deprecated `#![crate_id]` attribute, as well as the deprecated `--crate-file-name` command line option. See rust-lang/rust@c3ef04b for details. Note that this won't compile on the current master without #128 (or equivalent). I can rebase after a fix lands
bors
added a commit
to alexcrichton/cargo
that referenced
this pull request
Sep 2, 2014
On rust-lang/rust@ed47c47 (which landed yesterday via rust-lang/rust@b8ef5cf), `url.path` now returns a `Path`, not a `String`. This one-line patch makes cargo compile again (at least as of rust-lang/rust@b8ef5cf, the `crate_id` changes haven't reached me yet).
bors
added a commit
to alexcrichton/cargo
that referenced
this pull request
Sep 2, 2014
…crichton This solves warnings about the use of the deprecated `#![crate_id]` attribute, as well as the deprecated `--crate-file-name` command line option. See rust-lang/rust@c3ef04b for details. Note that this won't compile on the current master without rust-lang#128 (or equivalent). I can rebase after a fix lands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On rust-lang/rust@ed47c47 (which landed yesterday via rust-lang/rust@b8ef5cf),
url.pathnow returns aPath, not aString. This one-line patch makes cargo compile again (at least as of rust-lang/rust@b8ef5cf, thecrate_idchanges haven't reached me yet).