-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(shell): Use alternate to close links #13562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-build-execution
Area: anything dealing with executing the compiler
A-console-output
Area: Terminal output, colors, progress bar, etc.
A-timings
Area: timings
Command-doc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 8, 2024
weihanglo
approved these changes
Mar 8, 2024
Tested. Thanks! @bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 8, 2024
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2024
Update cargo 9 commits in a4c63fe5388beaa09e5f91196c86addab0a03580..7065f0ef4aa267a7455e1c478b5ccacb7baea59c 2024-03-06 22:15:17 +0000 to 2024-03-12 13:25:15 +0000 - chore: remove repetitive word (rust-lang/cargo#13575) - refactor(lockfile): Make diffing/printing more reusable (rust-lang/cargo#13564) - test: Add tests for using worktrees and sparse checkouts (rust-lang/cargo#13567) - util/network/http: Use `cargo/1.2.3` user-agent header (rust-lang/cargo#13548) - fix: Consistently compare MSRVs (rust-lang/cargo#13537) - refactor(shell): Use alternate to close links (rust-lang/cargo#13562) - fix(doc): Collapse down Generated statuses without --verbose (rust-lang/cargo#13557) - doc: Add doc for -Zpublic-dependency (rust-lang/cargo#13556) - docs: add link to the exported_private_dependencies lint (rust-lang/cargo#13547) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-build-execution
Area: anything dealing with executing the compiler
A-console-output
Area: Terminal output, colors, progress bar, etc.
A-timings
Area: timings
Command-doc
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Simplifies the code for includign hyperlinks, especially the fact that this allows for including the variable in the format string.
How should we test and review this PR?
Hand tested each case as we don't have SVG support for hyperlinks and we don't have SVG tests for these cases
Additional information