Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo #122394

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Update cargo #122394

merged 1 commit into from
Mar 12, 2024

Conversation

weihanglo
Copy link
Member

9 commits in a4c63fe5388beaa09e5f91196c86addab0a03580..7065f0ef4aa267a7455e1c478b5ccacb7baea59c
2024-03-06 22:15:17 +0000 to 2024-03-12 13:25:15 +0000

r? ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2024

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented Mar 12, 2024

📌 Commit e322fef has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2024
@bors
Copy link
Contributor

bors commented Mar 12, 2024

⌛ Testing commit e322fef with merge a165f1f...

@bors
Copy link
Contributor

bors commented Mar 12, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing a165f1f to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 12, 2024

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing a165f1f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 12, 2024
@bors bors merged commit a165f1f into rust-lang:master Mar 12, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 12, 2024
@weihanglo weihanglo deleted the update-cargo branch March 12, 2024 21:33
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a165f1f): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.1% [1.1%, 1.1%] 1
Improvements ✅
(primary)
-0.7% [-0.7%, -0.7%] 3
Improvements ✅
(secondary)
-0.5% [-0.6%, -0.3%] 5
All ❌✅ (primary) -0.7% [-0.7%, -0.7%] 3

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.268s -> 672.147s (-0.46%)
Artifact size: 310.30 MiB -> 310.26 MiB (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Mar 13, 2024
@weihanglo
Copy link
Member Author

Hmm… didn't get it. There is no change obviously affecting performance in Cargo. tt-muncher looks even less relevant.

@Kobzol
Copy link
Contributor

Kobzol commented Mar 13, 2024

I wouldn't worry about it. Updating cargo almost always introduces small perf. changes, unless something really large stands out, we usually don't deal with it.

@Kobzol
Copy link
Contributor

Kobzol commented Mar 13, 2024

The muncher change looks like noise, based on the historical chart.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants