Skip to content

Treat VxWorks wr-cc as a Gnu compiler #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2024
Merged

Treat VxWorks wr-cc as a Gnu compiler #1198

merged 1 commit into from
Sep 4, 2024

Conversation

biabbas
Copy link
Contributor

@biabbas biabbas commented Sep 4, 2024

Fixes #1197
Solution:

  1. Remove ci style arguments from command for wr-cc.
  2. Remove --target=value from command as this caused wr-cc to look for wrong target config file.

NobodyXu
NobodyXu approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NobodyXu NobodyXu merged commit 845052c into rust-lang:main Sep 4, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Sep 4, 2024
Merged
@biabbas biabbas deleted the vxworks branch September 5, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VxWorks wr-cc is detected as MSVC compiler, cc adds flags "no-logo", "W4" and "--" which causes compilation issues.
2 participants
@biabbas @NobodyXu