find_tool: Fallback to manually searching for tool dir if it can't otherwise be found #1526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
requested changes
Aug 21, 2025
ChrisDenton
force-pushed
the
tooldir-fallback
branch
from
f05decb to
b182823
Compare
ChrisDenton
force-pushed
the
tooldir-fallback
branch
from
b182823 to
307a88d
Compare
NobodyXu
requested changes
Aug 21, 2025
Co-Authored-By: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
ChrisDenton
force-pushed
the
tooldir-fallback
branch
from
307a88d to
321f0b6
Compare
NobodyXu
approved these changes
Aug 21, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all other methods fail, this attempts to find the MSVC tools bin path by checking for the existence of the bin subdirectory. As with other code, this picks the highest version from the possible candidates.
Ideally we'd also update the code for the recent Visual Studio changes but that would need more investigation and in any case this fallback will continue to be useful as a hedge against other changes that may break cc-rs.
Fixes #1525