Refactor: Extract windows-find-tools #1531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI semver failed due to false positive obi1kenobi/cargo-semver-checks#638 , temporarily disabling it until another release is made |
madsmtm
reviewed
Aug 25, 2025
Co-authored-by: Mads Marquart <mads@marquart.dk>
…is already occupied
|
I have to rename the crate to windows-find-tools since windows-registry is already taken |
NobodyXu
changed the title
madsmtm
reviewed
Aug 25, 2025
madsmtm
approved these changes
Aug 26, 2025
Co-authored-by: Mads Marquart <mads@marquart.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By extracting mod windows_registry out as a separate crate, we will have
windows-registrydoesn't have to pull in entire ccwindows-registrycodegen can be done in parallel to cc compilation, andwindows-registryspends ~80% of time in codegen