Use $WASI_SDK_PATH on WASI targets by default
#1562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates compiler detection logic to use the `$WASI_SDK_PATH` variable, if set, by default when looking up a compiler for WASI targets. This is commonly set in installations of wasi-sdk and it can be helpful to avoid the need to further configure how to find a WASI-specific compiler. CI for WASI was expanded here from `wasm32-wasip1-threads` to other WASI targets as well to ensure it works on all of Rust's targets.
|
I think github actions is having a bad day today, and in my experience it takes ~24 hours for an error like this to go away (maybe a bad cache somewhere? iunno). I'll try to remember to push some time tomorrow to kick CI and will ping here when green. |
|
Oh yay, tests look green now! |
|
er, sorry, that was the wrong button |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates compiler detection logic to use the
$WASI_SDK_PATHvariable, if set, by default when looking up a compiler for WASI targets. This is commonly set in installations of wasi-sdk and it can be helpful to avoid the need to further configure how to find a WASI-specific compiler.CI for WASI was expanded here from
wasm32-wasip1-threadsto other WASI targets as well to ensure it works on all of Rust's targets.