Skip to content

Conversation

madsmtm
Copy link
Collaborator

@madsmtm madsmtm commented Sep 27, 2025

Without this change, we end up passing aarch64-apple-ios26.0-macabimacabi to the compiler, which is definitely wrong.

The core change here is to handle this in from_cargo_environment_variables as well, the rest is just a cleanup now that target.env contains the canonical value (and target.abi).

See also the previous #1517 and #1534.

I really should've checked that this worked in cc-rs before landing rust-lang/rust#139451, sorry about that!

@madsmtm madsmtm added bug O-apple Apple targets and toolchains labels Sep 27, 2025
@madsmtm madsmtm force-pushed the macabi branch 3 times, most recently from 5cfc46a to 87c0aa1 Compare September 27, 2025 22:08
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you run the "Test nightly rustc targets and add issue comment if changed" just to make sure there's no regression?

@madsmtm
Copy link
Collaborator Author

madsmtm commented Sep 28, 2025

Can you run the "Test nightly rustc targets and add issue comment if changed" just to make sure there's no regression?

I ran the following locally, and that worked:

RUSTFLAGS=--cfg=rustc_target_test cargo +nightly test --lib

I don't know how to trigger a workflow on a PR?

Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

As oong as it can pass all tests, I'm be ok with it

@NobodyXu NobodyXu merged commit 89fb94c into rust-lang:main Sep 28, 2025
79 checks passed
@madsmtm madsmtm deleted the macabi branch September 28, 2025 14:15
@github-actions github-actions bot mentioned this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug O-apple Apple targets and toolchains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants