Mark static_flag and shared_flag as deprecated
#1582
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
requested changes
Oct 3, 2025
|
emmm, can we create a version 2.0 branch then? i can change the PR target. |
|
We have absolutely no plan for 2.0, that'll just render too many build script to stick to a 1.0 version so we'd either backport to maintain 1.0 or give them up, which is not realistic |
|
huh, and people really are using them even if they do nothing. how about i also add a |
Thanks this reminds me, some does use it to build shared lib I think?
Hmmm no that's bad, I'd prefer deprecated if we really want to do that |
it won't work though. all they would get is |
yshui
changed the title
static_flag and shared_flag as deprecated
They are meaningless since cc-rs only generates static libraries. Closes rust-lang#1444 Closes rust-lang#594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are meaningless since cc-rs only generates static libraries. Having them does nothing and only causes confusion.
Closes #1444
Closes #594