Skip to content

Conversation

Jules-Bertholet
Copy link

meta does not match true/false, so switch to tt.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small test requests. The impl itself looks good to me, but @nnethercote would you mind giving this a second set of eyes? Considering you've been looking at these patterns recently and they can be a bit tricky.

Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok. My only question is how is the behaviour changed if you do something erroneous like if #[cfg(99)]? Probably a different error message?

@Jules-Bertholet
Copy link
Author

Probably a different error message?

Yes, from “no rules expected `<token>` in macro call” to “cfg predicate key must be an identifier”. It’s an improvement, I think

@nnethercote
Copy link
Contributor

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants