-
Notifications
You must be signed in to change notification settings - Fork 134
Allow per-target cmake toolchain #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow per-target cmake toolchain #120
Conversation
841056b
to
b3efe67
Compare
Thanks! Could this be done for most other env var accesses as well? Additionally, like |
Right, so here are the two other environment variables where I think it'd make sense to make them per-target:
The other two, I'm not so sure:
|
For |
b3efe67
to
27f166e
Compare
5764ed1
to
344cff1
Compare
How does this look? It should now get the per-target environment variable for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me!
af53561
to
657055a
Compare
657055a
to
f9002a6
Compare
Thanks! |
This would help cross-compilation a bit, allowing the user to have some global environment variables set up for each of their cross-compilation toolchain.
The
get_target_env_var
function is taken fromcc-rs::get_var
function.