Skip to content

Resolve FIXMEs related to f16 assembly #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Resolve FIXMEs related to f16 assembly #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions testcrate/benches/float_extend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@ float_bench! {
sys_available: not(feature = "no-sys-f16"),
asm: [
#[cfg(target_arch = "aarch64")] {
// FIXME(f16_f128): remove `to_bits()` after f16 asm support (rust-lang/rust/#116909)
let ret: f32;
asm!(
"fcvt {ret:s}, {a:h}",
a = in(vreg) a.to_bits(),
a = in(vreg) a,
ret = lateout(vreg) ret,
options(nomem, nostack, pure),
);
Expand Down Expand Up @@ -96,9 +95,7 @@ pub fn float_extend() {
extend_f16_f32(&mut criterion);

#[cfg(f128_enabled)]
{
extend_f16_f128(&mut criterion);
}
extend_f16_f128(&mut criterion);
}

extend_f32_f64(&mut criterion);
Expand Down
14 changes: 5 additions & 9 deletions testcrate/benches/float_trunc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,15 @@ float_bench! {
sys_available: not(feature = "no-sys-f16"),
asm: [
#[cfg(target_arch = "aarch64")] {
// FIXME(f16_f128): remove `from_bits()` after f16 asm support (rust-lang/rust/#116909)
let ret: u16;
let ret: f16;
asm!(
"fcvt {ret:h}, {a:s}",
a = in(vreg) a,
ret = lateout(vreg) ret,
options(nomem, nostack, pure),
);

f16::from_bits(ret)
ret
};
],
}
Expand All @@ -37,16 +36,15 @@ float_bench! {
sys_available: not(feature = "no-sys-f16"),
asm: [
#[cfg(target_arch = "aarch64")] {
// FIXME(f16_f128): remove `from_bits()` after f16 asm support (rust-lang/rust/#116909)
let ret: u16;
let ret: f16;
asm!(
"fcvt {ret:h}, {a:d}",
a = in(vreg) a,
ret = lateout(vreg) ret,
options(nomem, nostack, pure),
);

f16::from_bits(ret)
ret
};
],
}
Expand Down Expand Up @@ -138,9 +136,7 @@ pub fn float_trunc() {
// FIXME(#655): `f16` tests disabled until we can bootstrap symbols
#[cfg(f16_enabled)]
#[cfg(not(any(target_arch = "powerpc", target_arch = "powerpc64")))]
{
trunc_f128_f16(&mut criterion);
}
trunc_f128_f16(&mut criterion);

trunc_f128_f32(&mut criterion);
trunc_f128_f64(&mut criterion);
Expand Down
Loading