Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also accept true and false on boolean flags #577

Closed
1 of 3 tasks
Nilstrieb opened this issue Jan 5, 2023 · 3 comments
Closed
1 of 3 tasks

Also accept true and false on boolean flags #577

Nilstrieb opened this issue Jan 5, 2023 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@Nilstrieb
Copy link
Member

Nilstrieb commented Jan 5, 2023 •
edited

Proposal

rustc currently accepts y, yes, on and n, no, off as arguments for boolean flags (stable ones like -Crpath and unstable ones like -Zbox-noalias).
This proposes to also accept true (meaning yes) and false (meaning no). trueand false are a natural way of expressing booleans and people sometimes make the mistake of using true or false only to then be rejected.
As we have three ways to describe them already, adding a fourth one shouldn't hurt anything (although it can be argued that three are enough).

Mentors or Reviewers

This is trivial to implement, I can do it myself

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@Nilstrieb Nilstrieb added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Jan 5, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jan 5, 2023
@jyn514
Copy link
Member

jyn514 commented Jan 5, 2023

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jan 5, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 12, 2023
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jan 18, 2023
@Nilstrieb Nilstrieb mentioned this issue Jan 18, 2023
Merged
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 19, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#107043 - Nilstrieb:true-and-false-is-false,…
8fc9ed5 
… r=wesleywiser

Support `true` and `false` as boolean flag params

Implements [MCP 577](rust-lang/compiler-team#577).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@apiraino @jyn514 @rustbot @Nilstrieb