Run main rust-analyzer tests in rust-lang/rust CI

[jieyouxu]

Proposal

Run main rust-analyzer tests in rust-lang/rust CI, not just the proc-macro-srv tiny subset. Given that rust-analyzer is something that Tier 1 target users can reasonably expect to work well, we should test rust-analyzer on Tier 1 targets in conjunction with in-tree compiler.

Implementation PR: rust-lang/rust#147372

Impact for compiler contributors

This can mean that some compiler changes can now cause rust-analyzer failures immediately observable in rust-lang/rust CI. However, I would expect the usual rustc_private test failure handling to occur, where if the compiler contributor doesn't know how to fix, they would ask the $tool (in this case, rust-analyzer) team for advice and assistance.

If such breakage proves to be too frequent, it is also possible to exercise options such as:

• Temporarily disable specific tests, or disable/revert enabling the main test suite.
• Revisit rust-analyzer tests that seem too sensitive/fragile.
• Limit which tests get run.

cc @rust-lang/rust-analyzer

Mentors or Reviewers

None specifically.

Process

The main points of the Major Change Process are as follows:

• File an issue describing the proposal.
• A compiler team member who is knowledgeable in the area can second by writing @rustbot second or kickoff a team FCP with @rfcbot fcp $RESOLUTION.
  • Refer to Proposals, Approvals and Stabilization docs for when a second is sufficient, or when a full team FCP is required.
• Once an MCP is seconded, the Final Comment Period begins.
  • Final Comment Period lasts for 10 days after all outstanding concerns are solved.
  • Outstanding concerns will block the Final Comment Period from finishing. Once all concerns are resolved, the 10 day countdown is restarted.
  • If no concerns are raised after 10 days since the resolution of the last outstanding concern, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

[rustbot]

Important

This issue is not meant to be used for technical discussion. There is a Zulip stream for that.
Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections can formally be registered here by adding a comment.

@rustbot concern reason-for-concern
<description of the concern>

Concerns can be lifted with:

@rustbot resolve reason-for-concern

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler