Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a repository for cargo-lockfile-sync #89

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@oli-obk
Copy link
Contributor

commented May 10, 2019

Originally suggested in rust-lang/rust#57443

This project is a custom crate that is independent of rustc, but will keep our toml files in sync with the lock files (rationale, see linked issue). Instead of putting that code in-tree, I want it to start out of tree immediately, since it's generally useful.

@oli-obk oli-obk added the T-compiler label May 10, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

@rfcbot pr merge

I propose we start out of tree immediately instead of pulling it out of tree later. Thus, this project starts out with no code, just an empty project with licenses and a README. The code already exists, but can only be added to an existing project by the author (see linked issue for details).

@rfcbot

This comment has been minimized.

Copy link

commented May 10, 2019

Team member @oli-obk has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@Zoxc

This comment has been minimized.

Copy link

commented May 10, 2019

It seems like this tool wouldn't fall under the compiler team.

@petrochenkov

This comment has been minimized.

Copy link

commented May 10, 2019

Why is updating versions in Cargo.tomls useful?

I assumed that they are supposed to be coarse-grained like regex = "1" (unless a specific bug-fix release regex = "1.X" is required for correct work).

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Why is updating versions in Cargo.tomls useful?

The original problem was that there are PRs that update just the lockfile, which seemed wrong to me. One example is rust-lang/rust#57435 where a version bump was necessary, but not reflected in the Cargo.toml. I don't know how many other such minimum version requirements are encoded solely in the Cargo.lock without the minimum version being specified in the Cargo.toml.

It seems like this tool wouldn't fall under the compiler team.

Is this more infra then?

@rfcbot

This comment has been minimized.

Copy link

commented May 18, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @oli-obk, I wasn't able to add the final-comment-period label, please do so.

@eddyb

This comment has been minimized.

Copy link
Member

commented May 22, 2019

I forgot to mention that cargo-edit might be a good place to put this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.