Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update promotion docs #67

Merged
merged 2 commits into from
May 13, 2021
Merged

update promotion docs #67

merged 2 commits into from
May 13, 2021

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 9, 2021 •
edited
Loading

"Explicit promotion" is no more 🎉 , so update the docs accordingly.

Blocked on rust-lang/rust#85110.

Fixes #35
Fixes #32

Fixes #53

@RalfJung RalfJung mentioned this pull request May 9, 2021
Closed
@RalfJung
Copy link
Member Author

RalfJung commented May 9, 2021 •
edited
Loading

I marked this as also closing #53. As far as I know, the only remaining "weirdness" of promotion is that const fn calls get promoted in const/static bodies, and this behavior is discussed at rust-lang/rust#80619. It makes the entire system a bit less clean than I would like, but it also makes it more convenient for users, so maybe that's an okay trade-off. rust-lang/rust#85112 ensures that rustc behaves correctly here.

@RalfJung
Copy link
Member Author

rust-lang/rust#85110 landed. :)

@RalfJung RalfJung merged commit 139f190 into rust-lang:master May 13, 2021
@RalfJung RalfJung deleted the promotion branch May 13, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solving the problem with promotion Update for promotion changes Describe promoted MIR quirks
2 participants
@RalfJung @oli-obk