Use Azure Pipelines for Windows instead of AppVeyor #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the AppVeyor configuration and adapts it for use on Azure Pipelines. For deployment, the maintainer must create a `docker-creds` variable group containing `DockerUsername` and `DockerPassword`. `DockerPassword` should be secret. This variable group must be linked to the particular build. Secrets are not visible to PR builds by default, which mitigates some of the security risks here. Still, it would be better to opt in to deployment as opposed to opting out of it with a `condition`.
ecstatic-morse
force-pushed
the
azure-pipelines
branch
from
24e2bab to
616076f
Compare
pietroalbini
requested changes
Jul 19, 2019
|
I made the requested changes. |
Co-Authored-By: Pietro Albini <pietro@pietroalbini.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newest available AppVeyor host runs Windows Server 2016. Since the Windows version in a container cannot be greater than that of the host, this requires that the Windows version of the published image also be Server 2016. However, we would like to run
craterusing process isolation, which on Server 2016 requires that the revision number of the host and container must also match. This requires that the Windows version on AppVeyor exactly matches the Windows version of a hypothetical crater agent. It's tough to find a correct image in the first place, and the revision number of the Windows used by AppVeyor may change unexpectedly.Instead, we want an image based on Windows 1803 or later, which removes the matching revision numbers constraint. Such machines are currently available via Azure Pipelines.
See the commit message for set-up instructions. @pietroalbini will likely want to improve this before it is merged, since they just set up Azure Pipelines on
rustcproper, while this is my first go at it.