Verify tarballs uploaded to crates.io contain at most one directory #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we'd just stream to S3 but they're all small enough (< 10MB) and we'll want to perform post-validation on them so we need the contents.
For now the only verification check we perform is that all entries in the tarball are contained in the correct path, which is a directory namespaced by the name of a crate and the version of a crate. Historical Cargo implementations don't verify this and could cause packages to overwrite one another's contents if custom tarballs were uploaded to crates.io
erickt
suggested changes
Sep 14, 2017
| // upload a tarball that contains both `foo-0.1.0/` source code as well | ||
| // as `bar-0.1.0/` source code, and this could overwrite other crates in | ||
| // the registry! | ||
| if !entry.path()?.starts_with(&prefix) { |
There was a problem hiding this comment.
Do you need a trailing '/', or is this looking at a whole directory entry?
There was a problem hiding this comment.
Can you add checks if any of the entries are: '..' or non-file/directories?
There was a problem hiding this comment.
The trailing / isn't necessary due to the way Path works, entries like .. are tested in tar itself, and non-file/directory entries are a feature, not a bug, but have extra handling in tar.
alexcrichton
added a commit
to alexcrichton/crates.io
that referenced
this pull request
Sep 14, 2017
Contains a test for rust-lang#1054
This was referenced Sep 14, 2017
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Sep 17, 2017
Verify tarballs don't extract into other directories Continuation of rust-lang/crates.io#1054 except support on the Cargo side of things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise they could accidentally overwrite other packages!