Begin preparation for Rust 2018 #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These attributes were causing problems with an automated migration to Rust 2018.
There are a few places where I left absolute paths because they commonly conflict with variable names: * `::json` * `::krate`
|
This is going to keep getting out of date and merge conflicty if we don't do it soon, and most of the other PRs already have merge conflicts sooooo bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Aug 30, 2018
1467: Begin preparation for Rust 2018 r=carols10cents a=jtgeibel This PR captures some of the results of my experimentation with `cargo fix`. The first 2 commits are required in order to get `cargo fix` to apply cleanly. In addition to these changes, there are 3 macros which cause problems in the automated conversion. I have not incorporated the fix for these macros because the `crate` keyword cannot be used in paths on current stable. I plan to file bugs against `cargo fix` for these 3 scenarios. The final commit explicitly `use`s things in preference to using absolute paths within functions. This commit isn't strictly required for a clean `cargo fix` run, but it will reduce unnecessary usage of the `crate` keyword one we run `cargo fix` for real. Co-authored-by: Justin Geibel <jtgeibel@gmail.com> Co-authored-by: Carol (Nichols || Goulding) <carol.nichols@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR captures some of the results of my experimentation with
cargo fix. The first 2 commits are required in order to getcargo fixto apply cleanly. In addition to these changes, there are 3 macros which cause problems in the automated conversion. I have not incorporated the fix for these macros because thecratekeyword cannot be used in paths on current stable. I plan to file bugs againstcargo fixfor these 3 scenarios.The final commit explicitly
uses things in preference to using absolute paths within functions. This commit isn't strictly required for a cleancargo fixrun, but it will reduce unnecessary usage of thecratekeyword one we runcargo fixfor real.