Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send email on crate owner invitation #1909

Merged
merged 2 commits into from Nov 25, 2019

Conversation

@nkanderson
Copy link
Contributor

nkanderson commented Nov 20, 2019

If the recipient of a crate ownership invitation has a verified email address, they will be sent an email indicating that a specified user has invited them to become an owner of a named crate. Only sends the email on the first instance of an invitation.

Completes the first part of #1360.

If the recipient of a crate ownership invitation has a verified email address, they will be sent an email indicating that a specified user has invited them to become an owner of a named crate. Only sends the email on the first instance of an invitation.
@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Nov 20, 2019

r? @jtgeibel

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Member

carols10cents left a comment

It's working great! I tried it out locally and I saw an email sent when I invited another user to a crate! 🎉

The code is really close! I think the email subject could use a tiny bit of tweaking, and we can get rid of a conditional in the krate model. Let me know if you have any questions! Thank you!!!

src/email.rs Outdated Show resolved Hide resolved
src/models/krate.rs Outdated Show resolved Hide resolved
@nkanderson

This comment has been minimized.

Copy link
Contributor Author

nkanderson commented Nov 22, 2019

I made the requested changes as an additional commit, but if preferred, I can squash that down to just the one.

@nkanderson nkanderson force-pushed the nkanderson:1360_email_invitation branch from 0c7de44 to cef0429 Nov 22, 2019
@nkanderson

This comment has been minimized.

Copy link
Contributor Author

nkanderson commented Nov 22, 2019

Whoops, looks like I had a formatting issue initially, should be ok now though.

@carols10cents

This comment has been minimized.

Copy link
Member

carols10cents commented Nov 25, 2019

Looks great now!! Thank you so much!!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 25, 2019

📌 Commit cef0429 has been approved by carols10cents

bors added a commit that referenced this pull request Nov 25, 2019
Send email on crate owner invitation

If the recipient of a crate ownership invitation has a verified email address, they will be sent an email indicating that a specified user has invited them to become an owner of a named crate. Only sends the email on the first instance of an invitation.

Completes the first part of #1360.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 25, 2019

⌛️ Testing commit cef0429 with merge 4df7001...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 25, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing 4df7001 to master...

@bors bors merged commit cef0429 into rust-lang:master Nov 25, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
percy/crates.io Visual review automatically approved, no visual changes found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.