Skip to content

Conversation

JonathanHelianthicusDoe

This adds some new @media queries to change the look of crates.io to a dark theme that respects the original design, any time the user agent has prefers-color-scheme: dark.

See the relevant MDN entry. Also note that in Firefox you can set ui.systemUsesDarkTheme to 1 (as an integer, not a string nor a boolean) to cause prefers-color-scheme to have the value dark.

The changes made are based on a usercss that I created. The usercss itself is actually CC BY-SA 4.0+ licensed, but just to be clear, I do of course license the contents of this PR dually under the MIT license and version 2.0 of the Apache license.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@locks
Copy link
Contributor

locks commented Dec 28, 2019

Thanks for contributing! I haven't discussed this work with the team, but if the decision is to move forward on this, we might want to figure out percy tests so we don't have regressions later on.

@smarnach
Copy link
Contributor

smarnach commented Jan 2, 2020

A dark theme sounds like a good idea! I haven't reviewed this PR, but in principle I'm in favour of merging this. Percy tests for this would be awesome as well.

@bors
Copy link
Contributor

bors commented Jan 7, 2020

☔ The latest upstream changes (presumably #2102) made this pull request unmergeable. Please resolve the merge conflicts.

@locks
Copy link
Contributor

locks commented Jan 11, 2020

Thank you for updating the PR!

@bors
Copy link
Contributor

bors commented Jan 13, 2020

☔ The latest upstream changes (presumably #2111) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Mar 20, 2020

☔ The latest upstream changes (presumably #2283) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Mar 24, 2020

☔ The latest upstream changes (presumably #2310) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Mar 27, 2020

☔ The latest upstream changes (presumably #2332) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87 Turbo87 removed the A-design label Apr 25, 2020
@Turbo87
Copy link
Member

Turbo87 commented Oct 14, 2020

@JonathanHelianthicusDoe hey, sorry this has been lingering for so long. the plan is to significantly revamp the whole design of the page in the next months and this dark scheme support would conflict with those plans at the moment. we can revisit this idea after the new design has landed though. due to these reasons I'll go ahead and close this PR for now. sorry! 😞

@Turbo87 Turbo87 closed this Oct 14, 2020
@teohhanhui
Copy link

the plan is to significantly revamp the whole design of the page in the next months

That sounds like the greatest opportunity to think dark theme-first.

@Turbo87
Copy link
Member

Turbo87 commented Oct 14, 2020

/cc @pichfl

@kotx
Copy link

kotx commented Jun 12, 2022

@Turbo87 @JonathanHelianthicusDoe hey, sorry this has been lingering for so long. the plan is to significantly revamp the whole design of the page in the next months and this dark scheme support would conflict with those plans at the moment. we can revisit this idea after the new design has landed though. due to these reasons I'll go ahead and close this PR for now. sorry! 😞

It's been a while, any updates on a dark theme?
Related: #4348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants