Skip to content

Replace tempdir with tempfile #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Replace tempdir with tempfile #2186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ docopt = "1.0"
scheduled-thread-pool = "0.2.0"
derive_deref = "1.0.0"
reqwest = "0.9.1"
tempdir = "0.3.7"
tempfile = "3"
parking_lot = "0.7.1"
jemallocator = { version = "0.3", features = ['unprefixed_malloc_on_supported_platforms', 'profiling'] }

Expand Down
4 changes: 2 additions & 2 deletions src/git.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use std::collections::HashMap;
use std::fs::{self, OpenOptions};
use std::path::{Path, PathBuf};
use swirl::PerformError;
use tempdir::TempDir;
use tempfile::{Builder, TempDir};
use url::Url;

use crate::background_jobs::Environment;
Expand Down Expand Up @@ -148,7 +148,7 @@ pub struct Repository {

impl Repository {
pub fn open(repository_config: &RepositoryConfig) -> Result<Self, PerformError> {
let checkout_path = TempDir::new("git")?;
let checkout_path = Builder::new().prefix("git").tempdir()?;

let repository = git2::build::RepoBuilder::new()
.fetch_options(Self::fetch_options(&repository_config.credentials))
Expand Down