Enable sorting crates by most recently added #2214
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jtgeibel (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
☔ The latest upstream changes (presumably #2209) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Thanks @RobbieClarken, these changes look great to me. It you rebase to resolve the merge conflicts I can r+. Thanks again! |
RobbieClarken
force-pushed
the
sort-by-newly-added
branch
2 times, most recently
from
462cd97 to
327d762
Compare
This change adds the option to sort by "Newly Added" on the following pages: - /crates - /search - /users/:user_id - /teams/:team_id - /keywords/:keyword_id - /categories/:category_id - /me/crates Sorting is performed using the `crates.created_at` column. Closes rust-lang#1919.
RobbieClarken
force-pushed
the
sort-by-newly-added
branch
from
327d762 to
975de2a
Compare
|
Thanks @jtgeibel, merge conflicts resolved. |
|
@bors r+ |
|
📌 Commit 975de2a has been approved by |
|
☀️ Test successful - checks-travis |
This change adds the option to sort crates by "Newly Added" on the following pages:
/crates/search/users/:user_id/teams/:team_id/keywords/:keyword_id/categories/:category_id/me/cratesSorting is performed using the
crates.created_atcolumn.I've put "Newly Added" as the last option in the dropdown:
Let me know if you would like a different label or for the order to be different.
I couldn't find any existing frontend tests of changing sort order. I'd be happy to add some as part of this PR if they would be valuable.
Closes #1919.