Replace ember-prism with highlight.js
#3878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
highlight.js is easier to integrate with the app (via ember-auto-import) and doesn't require us to use any global variables etc. The remaining two `<pre>` usages got a `.terminal` CSS class in this commit to avoid styling conflicts.
Turbo87
force-pushed
the
highlight-js
branch
from
b4b7e3b to
7ad1136
Compare
0xPoe
approved these changes
Sep 4, 2021
|
@bors r+ |
|
📌 Commit 7ad1136 has been approved by |
1 task
|
☀️ Test successful - checks-actions |
This was referenced Sep 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
highlight.js is easier to integrate with the app (via ember-auto-import) and doesn't require us to use any global variables or an ember-addon at all.
The remaining two
<pre>usages got a.terminalCSS class in this commit to avoid styling conflicts.