Skip to content

CrateSidebar: Show detailed list for small number of owners #4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 9, 2021

This PR extracts a OwnersList component and then adjusts it to show a more detailed list if the number of owners is five or less.

Before:

Bildschirmfoto 2021-11-09 um 20 24 00

After:

Bildschirmfoto 2021-11-09 um 20 23 41

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Nov 9, 2021
@Turbo87 Turbo87 requested review from locks and pichfl November 9, 2021 19:25
@locks
Copy link
Contributor

locks commented Nov 9, 2021

Love the change!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 9, 2021

📌 Commit 0971c51 has been approved by locks

@bors
Copy link
Contributor

bors commented Nov 9, 2021

⌛ Testing commit 0971c51 with merge 5fce71a...

@bors
Copy link
Contributor

bors commented Nov 9, 2021

☀️ Test successful - checks-actions
Approved by: locks
Pushing 5fce71a to master...

@bors bors merged commit 5fce71a into rust-lang:master Nov 9, 2021
@Turbo87 Turbo87 deleted the owners-list branch November 11, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants