Redesign 404 page #4154
Merged
Redesign 404 page #4154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
The logo comes from https://www.rustacean.net
|
@bors r+ |
|
📌 Commit 79636de has been approved by |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Nov 16, 2021
Show 404 pages for unknown crates/versions Instead of redirecting back to a known URL and showing a notification message, we now stay on the requested URL and show an error page instead. <img width="721" alt="Bildschirmfoto 2021-11-10 um 14 41 29" src="https://user-images.githubusercontent.com/141300/141200350-d31a3b60-79a9-43eb-b104-aee1238d55f3.png"> (though with "Crate/Version not found" instead) The implementation is a little questionable, but due to the way the `error` substates in Ember.js work I've found no other way to implement this. This PR is based on #4154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logo comes from https://www.rustacean.net