utils/license: Add support for parentheses #4257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
|
@bors r+ |
|
📌 Commit 0d1a444 has been approved by |
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Jan 14, 2024
Delete sentence about parentheses being unsupported in license Parentheses have been supported by crates.io since 2 years ago. - rust-lang/crates.io#4257 Their functionality is tested by this test: https://github.com/rust-lang/crates.io/blob/3acd63c1f3625d83322e4819d76296ae5ef291c5/tests/utils/license-test.js#L68-L79. I think a separate test in Cargo is most likely not valuable because Cargo does not parse these license strings, they are just treated as `Option<String>`. Here is an example of an extremely widely used package (147 million downloads) with parentheses in its license: https://crates.io/crates/unicode-ident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2595