Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete /authorize/github route #4397

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 2, 2022

This route has been replaced with the github-redirect.html file instead and is no longer needed.

Todo:

  • check if CSP configuration works with the inline JS in github-redirect.html

@Turbo87 Turbo87 added A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works labels Jan 2, 2022
@Turbo87
Copy link
Member Author

Turbo87 commented Jan 7, 2022

we have switched production over to the raw HTML page today. our plan is to monitor the situation for about a month and if there are no issues we will merge this PR and remove the obsolete route.

This hasn't been used for quite some time and has been replace with the `github-redirect.html` file instead.
@Turbo87 Turbo87 force-pushed the remove-obsolete-github-route branch from 1672849 to 50b1fa2 Compare January 13, 2022 23:40
@Turbo87 Turbo87 marked this pull request as ready for review February 7, 2022 09:06
@Turbo87
Copy link
Member Author

Turbo87 commented Feb 7, 2022

looks like no issues were reported since then, so I'll go ahead and merge this PR now.

@bors r+

@bors
Copy link
Contributor

bors commented Feb 7, 2022

📌 Commit 50b1fa2 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Feb 7, 2022

⌛ Testing commit 50b1fa2 with merge 6c0d5bf...

@bors
Copy link
Contributor

bors commented Feb 7, 2022

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing 6c0d5bf to master...

@bors bors merged commit 6c0d5bf into rust-lang:master Feb 7, 2022
@Turbo87 Turbo87 deleted the remove-obsolete-github-route branch February 7, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants