Skip to content

controllers::krate: Protect against null bytes in query string #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 11, 2022

Fixes #4538.

This does add a small string replace operation to the endpoint, but compared to the database queries the overhead should be negligible.

@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-backend ⚙️ labels Feb 11, 2022
@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 12, 2022

📌 Commit 16a5b4b has been approved by pietroalbini

@bors
Copy link
Contributor

bors commented Feb 12, 2022

⌛ Testing commit 16a5b4b with merge 0432608...

@bors
Copy link
Contributor

bors commented Feb 12, 2022

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 0432608 to master...

@bors bors merged commit 0432608 into rust-lang:master Feb 12, 2022
@Turbo87 Turbo87 deleted the null-byte branch February 13, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppErrToStdErr: invalid byte sequence for encoding "UTF8": 0x00
3 participants