Skip to content

Update Rust crate dashmap to v5.3.4 #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2022
Merged

Update Rust crate dashmap to v5.3.4 #4763

merged 2 commits into from
Jun 4, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 29, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
dashmap dependencies minor =5.2.0 -> =5.3.4

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/dashmap-5.x branch 2 times, most recently from c05e93a to d5beb50 Compare April 30, 2022 22:49
@renovate renovate bot changed the title Update Rust crate dashmap to v5.3.1 Update Rust crate dashmap to v5.3.2 Apr 30, 2022
@renovate renovate bot force-pushed the renovate/dashmap-5.x branch from d5beb50 to 52545f1 Compare May 2, 2022 16:46
@renovate renovate bot changed the title Update Rust crate dashmap to v5.3.2 Update Rust crate dashmap to v5.3.3 May 2, 2022
@Turbo87
Copy link
Member

Turbo87 commented May 9, 2022

@ehuss do you know if we are doing something wrong here? when I run cargo check locally on this branch I also get that version conflict error. shouldn't cargo resolve to two different versions in this case?

@ehuss
Copy link
Contributor

ehuss commented May 9, 2022

Cargo does not allow two semver-compatible versions to be used at the same time. Generally, tilde requirements shouldn't be used. It looks like something that should be fixed in claim.

@Turbo87
Copy link
Member

Turbo87 commented May 9, 2022

Cargo does not allow two semver-compatible versions to be used at the same time.

TIL, thanks!

@renovate renovate bot force-pushed the renovate/dashmap-5.x branch from 52545f1 to 5cd7d32 Compare May 19, 2022 12:23
@renovate renovate bot changed the title Update Rust crate dashmap to v5.3.3 Update Rust crate dashmap to v5.3.4 May 28, 2022
@renovate renovate bot force-pushed the renovate/dashmap-5.x branch from 5cd7d32 to 312253f Compare May 28, 2022 11:37
@Turbo87
Copy link
Member

Turbo87 commented May 31, 2022

This is blocked by svartalf/rust-claim#10

@renovate renovate bot force-pushed the renovate/dashmap-5.x branch from 312253f to 168ddbb Compare May 31, 2022 11:53
@Turbo87 Turbo87 force-pushed the renovate/dashmap-5.x branch from 168ddbb to 9142581 Compare June 2, 2022 13:06
@renovate renovate bot force-pushed the renovate/dashmap-5.x branch from 9142581 to 37efe06 Compare June 2, 2022 15:24
@Turbo87
Copy link
Member

Turbo87 commented Jun 2, 2022

@pietroalbini any clue how to resolve that typing issue? looks like dashmap is not reexporting the hashbrown types :-/

@Turbo87 Turbo87 force-pushed the renovate/dashmap-5.x branch from 37efe06 to 3b1755f Compare June 2, 2022 18:06
@Turbo87
Copy link
Member

Turbo87 commented Jun 2, 2022

@pietroalbini looks like I may have found a way to make it compile at least. could you take a look if this makes sense? 🙏

@Turbo87 Turbo87 force-pushed the renovate/dashmap-5.x branch from 3b1755f to fea6b22 Compare June 2, 2022 20:24
@Turbo87 Turbo87 removed the blocked label Jun 2, 2022
@pietroalbini
Copy link
Member

Yes, the code looks correct.

@Turbo87 Turbo87 merged commit 58db215 into master Jun 4, 2022
@Turbo87 Turbo87 deleted the renovate/dashmap-5.x branch June 4, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants