Always run background jobs after a test publish #5042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent was that tests would be able to enqueue mutliple
actions and process them more asynchronously to act as more of a stress
test of the background worker logic. However, we have no tests explicity
testing such behavior and we can always add back such methods if we
decide to implement such tests.
This change reorders some requests in the http-data files. For the most
part requests are unchanged, however now if 2 versions of a crate are
published in rapid succession the HTTP index is guarenteed to see both
versions of that file.
Previously, if versions A and B were published they would both go in
the background queue. When the queue was processed, the versions would
be published to the git index and each of those jobs would enqueue an
HTTP sync. However, those syncs would occur after the two publishes and
so both syncs would see the full index file with both versions. This is
not an issue in production, as there is no requirement to push such
intermediate states to the HTTP index as long as it is eventually
consistent. In testing however, it is a bit more convenient to see the
more typical sequence of events.
Some tests now require the full test harness, even if a crate publish
is expected to fail.
Extracted from #5022