Remove unnecessary borrows

src/controllers/krate/publish.rs

@@ -436,7 +436,7 @@ fn verify_tarball(
         // as `bar-0.1.0/` source code, and this could overwrite other crates in
         // the registry!
         let entry_path = entry.path()?;
-        if !entry_path.starts_with(&pkg_name) {
+        if !entry_path.starts_with(pkg_name) {
             return Err(cargo_err("invalid tarball uploaded"));
         }
         if entry_path == vcs_info_path {

src/email.rs

@@ -148,7 +148,7 @@ or go to https://{domain}/me/pending-invites to manage all of your crate ownersh
             EmailBackend::FileSystem { path } => {
                 add_custom_metadata("email_backend", "fs");
 
-                let id = FileTransport::new(&path).send(&email).map_err(|err| {
+                let id = FileTransport::new(path).send(&email).map_err(|err| {
                     add_custom_metadata("email_error", err);
                     server_error("Email file could not be generated")
                 })?;

src/tests/builders/publish.rs

@@ -229,7 +229,7 @@ impl PublishBuilder {
         );
         body.extend(json.as_bytes().iter().cloned());
 
-        body.extend(&[
+        body.extend([
             tarball.len() as u8,
             (tarball.len() >> 8) as u8,
             (tarball.len() >> 16) as u8,

src/worker/dump_db.rs

@@ -130,7 +130,7 @@ impl Drop for DumpDirectory {
 
 pub fn run_psql(script: &Path, database_url: &str) -> Result<(), PerformError> {
     debug!(?script, "Running psql script…");
-    let psql_script = File::open(&script)?;
+    let psql_script = File::open(script)?;
     let psql = std::process::Command::new("psql")
         .arg(database_url)
         .current_dir(script.parent().unwrap())

src/worker/git.rs

@@ -131,7 +131,7 @@ pub fn squash_index(env: &Environment) -> Result<(), PerformError> {
 
     // Shell out to git because libgit2 does not currently support push leases
 
-    repo.run_command(Command::new("git").args(&[
+    repo.run_command(Command::new("git").args([
         "push",
         // Both updates should succeed or fail together
         "--atomic",