models/krate: Move URL and name validation out of create_or_update()
#7185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`create_or_update()` is only called in four places. Three of them are within test code, where a `create()` fn would be sufficient and where we don't necessarily need the same kind of validation. The fourth place is the publish endpoint, where this validation is definitely needed, but could potentially be combined with other validation code in the future.
This function does not need to be on the `NewCrate` struct, since the only relevant field is `name` and we can pass that in as a `&str` instead.
Turbo87
added
C-internal 🔧
This function does not need to be on the `NewCrate` struct. Making it independent from the struct allows us to perform this validation much earlier in the process and combine it with other validations.
Turbo87
force-pushed
the
publish-validation
branch
from
79890a6 to
b9bce51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reserved name and URL validations are somewhat unrelated to the
NewCratestruct and are much more useful as independent validations, that can be run in combination with some of the other publish validations that we have (e.g. missing/empty metadata fields or the Cargo.toml content validation).This PR extracts that functionality and moves it to the publish module instead.