publish: Introduce dependency limit #7916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing users to publish crates with an unlimited number of dependencies has the potential to cause various issues. The crate with the most dependencies currently has 256 dependencies, so a limit of 500 dependencies seems reasonable for now. If necessary, we can make this limit configurable with an environment variable in the future, or even per crate with another database column.
Turbo87
added
C-enhancement ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing users to publish crates with an unlimited number of dependencies has the potential to cause various issues. The crate with the most dependencies currently has 256 dependencies, so a limit of 500 dependencies seems reasonable for now. If necessary, we can make this limit configurable with an environment variable in the future, or even per crate with another database column.
see https://rust-lang.zulipchat.com/#narrow/stream/318791-t-crates-io/topic/dependencies.20limit