Skip to content

CrateSidebar: Fix @hasLib assignment #9106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jul 17, 2024

has_lib: false was still showing the "Install as library" section, and looking at the code I can only πŸ€¦β€β™‚οΈ πŸ˜‚

This PR fixes the broken assignment so that https://crates.io/crates/ripgrep will no longer show that section. The PR also includes a tiny styling tweak to make the margins between the sidebar sections consistent in this case.

@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-frontend 🐹 labels Jul 17, 2024
@Turbo87 Turbo87 enabled auto-merge July 17, 2024 06:45
@Turbo87 Turbo87 changed the title CrateSidebar: Fix @hasLib assignment CrateSidebar: Fix @hasLib assignment Jul 17, 2024
@Turbo87 Turbo87 merged commit 6b90fbb into rust-lang:main Jul 17, 2024
8 of 9 checks passed
@Turbo87 Turbo87 deleted the cargo-install branch July 17, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant