fix N+1 queries when fetching crate details #1239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphar
force-pushed
the
docpage-performance
branch
from
df05fde to
39fd138
Compare
|
I looked up the commit that introduced these queries to be sure there wasn't a reason to do this it was ccd10d6 , roughly a year ago |
Nemo157
approved these changes
Jan 5, 2021
jyn514
referenced
this pull request
Jan 7, 2021
CrateDetails: replace field 'versions' with 'releases', which contains both the version and the build status of a release. Since CrateDetails::versions was a public field, CrateDetails::versions() is designed to be compatible with the previous exposed field.
jyn514
approved these changes
Jan 7, 2021
| row.get("is_library"), | ||
| ) | ||
| }); | ||
| .unwrap() |
There was a problem hiding this comment.
We should probably fix this at some point, but it doesn't need to happen here.
jyn514
added
the
S-waiting-on-deploy
pietroalbini
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There we some unnecessary repetitions in the statements. Version-Details were fetched for every version/release with a separate statement.
This was the first reason I found to slow rustdoc pages down.
Local manual tests look fine for me, but a second pair of eyes likely is good :)
(I'm happy to implement any improvements needed)