Skip to content

Remove pc-windows-gnu targets #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

onur
Copy link
Member

@onur onur commented Oct 24, 2018

When I switched custom Rust builds, I never provided a build for pc-windows-gnu targets and nobody asked for them. I think it's safe to remove this targets from docs.rs to save up some space.

@onur onur requested a review from QuietMisdreavus October 24, 2018 21:44
@onur onur force-pushed the remove-pc-window-gnu-targets branch from a746654 to 336aec7 Compare October 24, 2018 21:45
@QuietMisdreavus
Copy link
Member

cc @retep998, do you know of any crates that would be negatively affected if docs.rs stopped generating docs for windows-gnu targets?

@retep998
Copy link
Member

In general there should be no API differences between -gnu and -msvc. However there are some crates that fail to build under -msvc such as the GTK crates.

@onur
Copy link
Member Author

onur commented Oct 24, 2018

docs.rs can only build gtk crates for x86_64-unknown-linux-gnu platform since they need an external system dependency. Removing pc-windows-gnu targets doesn't make any difference for those crates.

Copy link
Member

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, it doesn't seem like too much of a problem to merge this.

@QuietMisdreavus QuietMisdreavus merged commit c2fd4ba into rust-lang:master Oct 24, 2018
@onur onur deleted the remove-pc-window-gnu-targets branch February 18, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants