Skip to content

[WIP] Update dependencies and iron 0.4 transition #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

onur
Copy link
Member

@onur onur commented Sep 1, 2016

This patch updates dependencies, but looks like there is a problem on templates.

@sunng87 I hope you can help :-)

cargo update performed:

    Updating handlebars v0.16.1 -> v0.18.2
    Updating handlebars-iron v0.15.2 -> v0.15.3
    Updating iron v0.3.0 -> v0.3.1

But looks like this template is no longer working. Problem is getting items from a vector of tuples. I have authors: Vec<(String, String)> and I was getting them with:

{{#each authors}}
<li class="pure-menu-item"><a href="/releases/{{this.[1]}}" class="pure-menu-link">{{this.[0]}}</a></li>
{{/each}}

This syntax is a RenderError now and this.[0] is no longer working.

@sunng87
Copy link

sunng87 commented Sep 2, 2016

Could you please update to handlebars-iron 0.18 which uses handlebars 0.20.5?
This should be fixed in that version.

@onur
Copy link
Member Author

onur commented Sep 2, 2016

@sunng87 looks like I have to upgrade iron to 0.4 as well.

@sunng87
Copy link

sunng87 commented Sep 2, 2016

I see. Is there any road blocker for upgrading to iron 0.4?
If you have issue with upgrading, I will make a back-port later.

@onur
Copy link
Member Author

onur commented Sep 2, 2016

Since everything is working fine with the current version, there is no need to back-port.

Upgrading iron is causing some problems. I was manipulating iron::Url.path in rustdoc handlers but it is no longer possible in iron 0.4 and I have to write a workaround.

I'll focus on more important issues rather than upgrading dependencies for now.

@onur onur changed the title Update dependencies [WIP] Update dependencies Sep 3, 2016
@onur onur changed the title [WIP] Update dependencies [WIP] Update dependencies and iron 0.4 transition Sep 3, 2016
@onur onur closed this in c8d1443 Oct 18, 2016
@onur onur deleted the update-dependencies branch October 18, 2016 21:58
hadronized pushed a commit to hadronized/docs.rs that referenced this pull request Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants