Skip to content

Handle renamed crates#487

Merged
jyn514 merged 1 commit into
rust-lang:masterfrom
emilyalbini:renamed-crates
Nov 25, 2019
Merged

Handle renamed crates#487
jyn514 merged 1 commit into
rust-lang:masterfrom
emilyalbini:renamed-crates

Conversation

@emilyalbini
Copy link
Copy Markdown
Member

Fixes #477
r? @jyn514

Copy link
Copy Markdown
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this will crash the builder for targets that aren't libraries, that should be fixed before this is merged. Everything else is pretty minor.

Comment thread src/db/add_package.rs Outdated
Comment thread src/db/add_package.rs Outdated
Comment thread src/docbuilder/rustwide_builder.rs Outdated
Comment thread src/utils/cargo_metadata.rs Outdated
Comment thread src/utils/cargo_metadata.rs Outdated
@emilyalbini
Copy link
Copy Markdown
Member Author

Addressed review comments.

@jyn514 jyn514 merged commit a6e6aa9 into rust-lang:master Nov 25, 2019
@jyn514
Copy link
Copy Markdown
Member

jyn514 commented Nov 25, 2019

Looks great!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing documentation, possibly due to package renaming

2 participants