Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle renamed crates #487

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Handle renamed crates #487

merged 1 commit into from
Nov 25, 2019

Conversation

pietroalbini
Copy link
Member

Fixes #477
r? @jyn514

@pietroalbini pietroalbini mentioned this pull request Nov 25, 2019
Closed
jyn514
jyn514 suggested changes Nov 25, 2019
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that this will crash the builder for targets that aren't libraries, that should be fixed before this is merged. Everything else is pretty minor.

src/db/add_package.rs Outdated Show resolved Hide resolved
src/db/add_package.rs Outdated Show resolved Hide resolved
src/docbuilder/rustwide_builder.rs Outdated Show resolved Hide resolved
src/utils/cargo_metadata.rs Outdated Show resolved Hide resolved
src/utils/cargo_metadata.rs Outdated Show resolved Hide resolved
@pietroalbini
Copy link
Member Author

Addressed review comments.

@jyn514 jyn514 merged commit a6e6aa9 into rust-lang:master Nov 25, 2019
@jyn514
Copy link
Member

jyn514 commented Nov 25, 2019

Looks great!

image

@pietroalbini pietroalbini deleted the renamed-crates branch November 25, 2019 14:42
This was referenced Nov 26, 2019
Closed
Merged
@jyn514 jyn514 mentioned this pull request Dec 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing documentation, possibly due to package renaming
2 participants
@pietroalbini @jyn514