-
Notifications
You must be signed in to change notification settings - Fork 17
Add support for multiple integers value for attribute and NonNull
#28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4f9cb91
to
c9399a8
Compare
9adf672
to
09c9f6f
Compare
gcc:
libgccjit:
With this C code: __attribute__((nonnull(1)))
int t(int *a) {
if (!a) {
return -1;
}
else {
return *a;
}
} We need to understand why range isn't updated with gccjit: gcc:
vs libgccjit:
|
641c166
to
0c99215
Compare
All fixed. Now remains to move the check earlier (in |
0c99215
to
21fc0e8
Compare
gcc/jit/jit-playback.cc
Outdated
continue; | ||
|
||
tree tree_list = NULL_TREE; | ||
tree *pp = &tree_list; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like a more descriptive name than pp
.
gcc/jit/jit-playback.h
Outdated
@@ -113,7 +115,8 @@ class context : public log_user | |||
int is_variadic, | |||
enum built_in_function builtin_id, | |||
const std::vector<gcc_jit_fn_attribute> &attributes, | |||
const std::vector<std::pair<gcc_jit_fn_attribute, std::string>> &string_attributes, | |||
const std::vector<std::pair<gcc_jit_fn_attribute, std::string>> &string_attributes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the tabs got lost here.
21fc0e8
to
6f65575
Compare
Questions to ask David when we'll send the attributes patch upstream:
|
For now this implementation doesn't work. Need to figure out what I did wrong.