feat(RValue): Allow Setting Locations after Creation #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also: rust-lang/rustc_codegen_gcc#69 |
|
Requires rust-lang/gcc#42 |
|
The CI should now be fixed. Please rebase to have the fix. |
This was referenced Feb 24, 2024
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's necessary for a minimal modification to the file in order to support native locations of libgccjit.
e.g. The support of
cg_gccfor operators, in builder.rs, implemented using a version using the binary operator*, which hard coded the location to be NULL. This must be filled by this set_location();e.g. It may be necessary to set location for locals introduced by cg_ssa, which seems to be stored by
DebugInfoBuilderMethods::dbg_var_addr. To save the location of the rvalue, we need aset_location().