ssh_key_from_memory no longer respected

[mwhudson]

(Disclaimer: I'm very new at this)

It seems to me that one of the side effects of alexcrichton@76f4b74#diff-612b86ed90c06a3454760b47abd89aea was that the ssh_key_from_memory feature is no longer checked independently of the ssh feature, i.e. GIT_SSH_MEMORY_CREDENTIALS is always defined if GIT_SSH is. This broke my backport of cargo to an older release of Ubuntu where libssh2 is a bit old.

[alexcrichton]

Oh oops, sorry about this! I was assuming that we'd always be building libssh2 from source (erroneously) and was looking to remove the opt-in needed for this API. Would it be possible to build libssh2 bundled like you're buliding libgit2 bundled?

[mwhudson]

I guess so, but where does that end? In any case having the ssh_key_from_memory there but ignored definitely doesn't seem right! It seems very easy to respect it, I guess I can add a patch for that if you'd be willing to take it.

PS: sorry for the slow reply!

[alexcrichton]

Oh sure yeah, either way's fine by me!

[martinvonz]

It's been a while and no one seems to have missed having the option to disable ssh_key_from_memory. Should we just delete the feature? Is the next version bump to 0.20.0 sufficient or do Rust projects prefer to just document features as deprecated?