Automate commit testing with proper stashing #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just running cargo check &&
cargo testIs probably enough, but for sake of completeness I can always make equivalent to travis-ci with some version of: cargo test --no-default-features
cargo test
cargo run --manifest-path systest/Cargo.toml --release |
|
Thanks! Since hooks have to be manually set up though I'm not sure if this belongs in the repo? Perhaps this could be listed in the README with a link to a gist? |
|
It depends on what you want to prioritize I suppose; I imagine it's less likely someone would go through the process of downloading it and copy pasting versus just doing a symlink. But I'm happy to go that route! It's definitely just my preference to do it this way. |
|
Ok sure yeah, let's go with the route of a snippet in the README |
Add a installation instructions for a git hook to automate testing done on each commit. Promotes proper handling of edge cases related to testing code that will not be in the commit, which masks errors that show up later as a nasty surprise. Fully opt in, links to a gist on github.
|
Gist found here. Updated, it should be good! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a git hook with installation instructions to automate testing done on each commit. Promotes proper handling of edge cases related to testing code that will not be in the commit, which masks errors that show up later as a nasty surprise.
It's opt-in, to install it simply use:
$ ln -s ../../.pre-commit.sh .git/hooks/pre-commit $ chmod +x .pre-commit.sh # for good measure