Support for building refactored libgit2 sources for vendored-libgit2 feature
#822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed libgit2 Since libgit2/libgit2@3a3ab06 libgit2 is refactored into a library and CLI. This change allows git2-rs to build those sources when the copy is used. This should not be integrated until a libgit2 release is made incorporating those sources. The libgit2 submodule has been updated at the current commit on libgit2's `main` branch.
|
Thanks! |
|
@alexcrichton Do we want to keep libgit2-sys tied to specific tagged releases? If so, this may make it difficult to make releases with changes until the next upstream release. |
|
In general since we use pkg-config to find a system version I think we need to follow the upstream, but I figured that this was ok since there wasn't any ABI changes so whether or not the system version is used the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since libgit2/libgit2@3a3ab06 libgit2 is refactored into a library and CLI. This change allows git2-rs to build those sources when the copy is used.
This should not be integrated until a libgit2 release is made incorporating those sources. The libgit2 submodule has been updated at the current commit on libgit2's
mainbranch.