Add bindings for push_negotiation callback #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
reviewed
Apr 1, 2023
src/remote_callbacks.rs
Outdated
| /// commands to the destination. | ||
| /// | ||
| /// The return value indicates whether the push should continue. | ||
| pub type PushNegotiation<'a> = dyn FnMut(&[PushUpdate<'_>]) -> bool + 'a; |
There was a problem hiding this comment.
Is there any particular reason this returns a bool? I was thinking it could return a Result<(), Error>, similar to other callbacks so that it is clear that it is triggering an error. A bool seems more innocuous, and not a typical way to do error handling in Rust.
There was a problem hiding this comment.
Thanks for the review! I've made the changes. I might have been emulating sideband_progress, where the callback also returns a bool to decide whether to cancel the operation, but using a Result is indeed more idiomatic here.
ehuss
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #733 .
This PR adds
RemoteCallbacks::push_negotiation,PushNegotiationandPushUpdateto expose thepush_negotiationcallback. A test is added at the end ofsrc/remote.rs.