Update to std::path #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @blaenk Curious what you think of the fallout in the tests. The most interesting gotcha for me was that |
|
Awww man, sorry about that. I was actually working on this a few weeks ago but got stalled due to missing APIs. @aturon was nice enough to expose them (e.g. |
| fn check_windows_verbatim(p: &Path) -> bool { path::windows::is_verbatim(p) } | ||
| fn check_windows_verbatim(p: &Path) -> bool { | ||
| use std::path::Prefix; | ||
| match p.components().next() { |
There was a problem hiding this comment.
Should be able to use Prefix::is_verbatim
|
This is excellent! I'll try to remember to swap out the |
alexcrichton
force-pushed
the
update
branch
3 times, most recently
from
2e99a06 to
a5765f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.