Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powerpc64-unknown-freebsd target #1358

Merged
merged 4 commits into from
May 25, 2019
Merged

Add powerpc64-unknown-freebsd target #1358

merged 4 commits into from
May 25, 2019

Conversation

pkubaj
Copy link
Contributor

@pkubaj pkubaj commented May 23, 2019

Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.

Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented May 23, 2019

Thanks for the PR, you might want to add here aarch64 as well.

FYI, this repo has nothing to do with stdsimd. My comment there was suggesting setting up a similar system as the one set up here, but on that repo, to be able to test these targets there as well.

@gnzlbg
Copy link
Contributor

gnzlbg commented May 24, 2019

You need to add these targets to the RUST_NIGHTLY_LINUX_TARGETS variable, since these are only available on nightly.

Move to RUST_NIGHTLY_LINUX_TARGETS per gznlbg's suggestion.
@gnzlbg
Copy link
Contributor

gnzlbg commented May 24, 2019

Damn, they need to be in the "LINUX_NO_CORE_TARGETS" apparently: https://github.com/rust-lang/libc/pull/1358/files#diff-78b1794b72c7105dbabbe466019395d6L170

 Move to LINUX_NO_CORE_TARGETS per gznlbg's suggestion.
@gnzlbg
Copy link
Contributor

gnzlbg commented May 25, 2019

Thank you! Now it worked!

@bors: r+

@bors
Copy link
Contributor

bors commented May 25, 2019

📌 Commit 49271b7 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented May 25, 2019

⌛ Testing commit 49271b7 with merge 0b2e18f...

bors added a commit that referenced this pull request May 25, 2019
Add powerpc64-unknown-freebsd target

Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
@bors
Copy link
Contributor

bors commented May 25, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor

gnzlbg commented May 25, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented May 25, 2019

⌛ Testing commit 49271b7 with merge 5588425...

bors added a commit that referenced this pull request May 25, 2019
Add powerpc64-unknown-freebsd target

Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
@bors
Copy link
Contributor

bors commented May 25, 2019

💔 Test failed - checks-travis

@gnzlbg
Copy link
Contributor

gnzlbg commented May 25, 2019

@bors: retry

gnzlbg added a commit to gnzlbg/libc that referenced this pull request May 25, 2019
Add powerpc64-unknown-freebsd target

Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
bors added a commit that referenced this pull request May 25, 2019
Rollup of 4 pull requests

Successful merges:

 - #503 (Set the type for S_ISUID, S_ISGID and S_ISVTX correctly)
 - #511 (Fix android SA_* constants)
 - #1358 (Add powerpc64-unknown-freebsd target)
 - #1364 (Deprecate mach APIs: users should use the `mach` crate instead.)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented May 25, 2019

⌛ Testing commit 49271b7 with merge 6d4c60d...

bors added a commit that referenced this pull request May 25, 2019
Add powerpc64-unknown-freebsd target

Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
@bors
Copy link
Contributor

bors commented May 25, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 6d4c60d to master...

@bors bors merged commit 49271b7 into rust-lang:master May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants